Pac file test #1829
Open
Pac file test #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PAC file support via PERCY_PAC_FILE_PATH env var * Added pac-proxy-agent lib as dependency * typo fixes * PR comments addressed * Moved pac-proxy-agent lib dependency to percy client instead of main package * Resolved conflicts
* Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> * Removed trailing space --------- Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com>
* Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> * Removed trailing space * Fix import of PERCY_DOM in line w ESM req * made a minor comment change --------- Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com>
* Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> * Removed trailing space * Fix import of PERCY_DOM in line w ESM req * made a minor comment change * Added PERCY_FORCE_DIRNAME flag in getPackageJSON util method * Env var name updated to PERCY_FORCE_EXECUTABLE_DIRNAME Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> --------- Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com>
* Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME * Bumped the percy tag to 1.30.3-alpha.4
bhutianimukul
requested review from
prklm10 and
shantanuk-browserstack
and removed request for
a team
|
LGTM! |
prklm10
reviewed
Dec 24, 2024
| @@ -83,6 +83,8 @@ export class PercyClient { | |||
|
|
|||
| // Stringifies client and environment info. | |||
| userAgent() { | |||
| if (this.env.forcedPkgValue) pkg = this.env.forcedPkgValue; | |||
There was a problem hiding this comment.
Add that this is added by LCNC team and why?
prklm10
reviewed
Dec 24, 2024
|
|
||
| if (($# < 1)); then | ||
| printf "usage: \n" | ||
| printf " ./get_chromuim [-r] rev - will get chromium by revision\n" |
prklm10
reviewed
Dec 24, 2024
|
|
||
| export REVISION=$1 | ||
|
|
||
| for os in "Linux" "Mac" "Mac_Arm" "Win" "Win_x64"; |
There was a problem hiding this comment.
from where this bash file is getting called?
There was a problem hiding this comment.
is this something lcnc calling internally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did the fixes for test case failing and added tests for test coverage
Reference PR
#1787